yutou/tachiyomi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Avoid throw as it is slow expensive operations

Browse Source
This commit is contained in:
quangkieu 2022-03-10 15:20:37 -05:00 committed by arkon
parent 1613d561c1
commit 9547311d7d
1 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateService.kt
View File

@ -313,32 +313,34 @@ class LibraryUpdateService(
manga, manga,
) { manga -> ) { manga ->
try { try {
if (MANGA_NON_COMPLETED in restrictions && manga.status == SManga.COMPLETED) { when {
throw SkipUpdateException(getString(R.string.skipped_reason_completed)) MANGA_NON_COMPLETED in restrictions && manga.status == SManga.COMPLETED -> {
} skippedUpdates.add(manga to getString(R.string.skipped_reason_completed))
if (MANGA_HAS_UNREAD in restrictions && manga.unreadCount != 0) {
throw SkipUpdateException(getString(R.string.skipped_reason_not_caught_up))
}
if (MANGA_NON_READ in restrictions && manga.totalChapters > 0 && !manga.hasStarted) {
throw SkipUpdateException(getString(R.string.skipped_reason_not_started))
}
val (newChapters, _) = updateManga(manga)
if (newChapters.isNotEmpty()) {
if (manga.shouldDownloadNewChapters(db, preferences)) {
downloadChapters(manga, newChapters)
hasDownloads.set(true)
} }
MANGA_HAS_UNREAD in restrictions && manga.unreadCount != 0 -> {
skippedUpdates.add(manga to getString(R.string.skipped_reason_not_caught_up))
}
MANGA_NON_READ in restrictions && manga.totalChapters > 0 && !manga.hasStarted -> {
skippedUpdates.add(manga to getString(R.string.skipped_reason_not_started))
}
else -> {
// Convert to the manga that contains new chapters
val (newChapters, _) = updateManga(manga)
// Convert to the manga that contains new chapters if (newChapters.isNotEmpty()) {
newUpdates.add( if (manga.shouldDownloadNewChapters(db, preferences)) {
manga to newChapters.sortedByDescending { ch -> ch.source_order } downloadChapters(manga, newChapters)
.toTypedArray() hasDownloads.set(true)
) }
// Convert to the manga that contains new chapters
newUpdates.add(
manga to newChapters.sortedByDescending { ch -> ch.source_order }
.toTypedArray()
)
}
}
} }
} catch (e: SkipUpdateException) {
skippedUpdates.add(manga to e.message)
} catch (e: Throwable) { } catch (e: Throwable) {
val errorMessage = when (e) { val errorMessage = when (e) {
is NoChaptersException -> { is NoChaptersException -> {
@ -587,5 +589,3 @@ class LibraryUpdateService(
private const val MANGA_PER_SOURCE_QUEUE_WARNING_THRESHOLD = 60 private const val MANGA_PER_SOURCE_QUEUE_WARNING_THRESHOLD = 60
private const val ERROR_LOG_HELP_URL = "https://tachiyomi.org/help/guides/troubleshooting" private const val ERROR_LOG_HELP_URL = "https://tachiyomi.org/help/guides/troubleshooting"
private class SkipUpdateException(override val message: String) : RuntimeException()