From 8417f5a63c6965ebd1794a308815fcbeb210e004 Mon Sep 17 00:00:00 2001
From: arkon <eugcheung94@gmail.com>
Date: Sat, 29 Oct 2022 16:35:32 -0400
Subject: [PATCH] Add more context to obsolete extension warning

---
 .../browse/ExtensionDetailsScreen.kt             | 16 ++++++----------
 .../kanade/presentation/updates/UpdatesScreen.kt |  2 +-
 i18n/src/main/res/values/strings.xml             |  4 ++--
 3 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/app/src/main/java/eu/kanade/presentation/browse/ExtensionDetailsScreen.kt b/app/src/main/java/eu/kanade/presentation/browse/ExtensionDetailsScreen.kt
index f8b20483e..7c528092a 100644
--- a/app/src/main/java/eu/kanade/presentation/browse/ExtensionDetailsScreen.kt
+++ b/app/src/main/java/eu/kanade/presentation/browse/ExtensionDetailsScreen.kt
@@ -9,7 +9,6 @@ import androidx.compose.foundation.background
 import androidx.compose.foundation.clickable
 import androidx.compose.foundation.interaction.MutableInteractionSource
 import androidx.compose.foundation.layout.Arrangement
-import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.PaddingValues
 import androidx.compose.foundation.layout.Row
@@ -197,19 +196,16 @@ private fun ExtensionDetails(
 
 @Composable
 private fun WarningBanner(@StringRes textRes: Int) {
-    Box(
+    Text(
+        text = stringResource(textRes),
         modifier = Modifier
             .fillMaxWidth()
             .background(MaterialTheme.colorScheme.error)
             .padding(16.dp),
-        contentAlignment = Alignment.Center,
-    ) {
-        Text(
-            text = stringResource(textRes),
-            color = MaterialTheme.colorScheme.onError,
-            style = MaterialTheme.typography.bodyMedium,
-        )
-    }
+        color = MaterialTheme.colorScheme.onError,
+        style = MaterialTheme.typography.bodyMedium,
+        textAlign = TextAlign.Center,
+    )
 }
 
 @Composable
diff --git a/app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt b/app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt
index d43aa7f2c..dc54ff111 100644
--- a/app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt
+++ b/app/src/main/java/eu/kanade/presentation/updates/UpdatesScreen.kt
@@ -143,7 +143,7 @@ private fun UpdateScreenContent(
             if (presenter.lastUpdated > 0L) {
                 updatesLastUpdatedItem(presenter.lastUpdated)
             }
-            
+
             updatesUiItems(
                 uiModels = presenter.uiModels,
                 selectionMode = presenter.selectionMode,
diff --git a/i18n/src/main/res/values/strings.xml b/i18n/src/main/res/values/strings.xml
index d85d7b1db..ce771f915 100644
--- a/i18n/src/main/res/values/strings.xml
+++ b/i18n/src/main/res/values/strings.xml
@@ -284,7 +284,7 @@
     <string name="ext_app_info">App info</string>
     <string name="untrusted_extension">Untrusted extension</string>
     <string name="untrusted_extension_message">This extension was signed with an untrusted certificate and wasn\'t activated.\n\nA malicious extension could read any login credentials stored in Tachiyomi or execute arbitrary code.\n\nBy trusting this certificate you accept these risks.</string>
-    <string name="obsolete_extension_message">This extension is no longer available.</string>
+    <string name="obsolete_extension_message">This extension is no longer available. It may not function properly and can cause issues with the app. Uninstalling it is recommended.</string>
     <string name="unofficial_extension_message">This extension is not from the official Tachiyomi extensions list.</string>
     <string name="extension_api_error">Failed to get extensions list</string>
     <string name="ext_info_version">Version</string>
@@ -826,7 +826,7 @@
 
     <!--UpdateCheck Notifications-->
     <string name="update_check_notification_download_in_progress">Downloading…</string>
-    <string name="update_check_notification_download_complete">Tap to install</string>
+    <string name="update_check_notification_download_complete">Tap to install update</string>
     <string name="update_check_notification_download_error">Download error</string>
     <string name="update_check_notification_update_available">New version available!</string>
     <string name="update_check_fdroid_migration_info">A new version is available from the official releases. Tap to learn how to migrate from unofficial F-Droid releases.</string>